From: Shakur Shams Mullick <shakursmullick@gmail.com>
To: util-linux@vger.kernel.org
Cc: Shakur Shams Mullick <shakursmullick@gmail.com>
Subject: [PATCH v2 7/8] libsmartcols/src/table_print.c: sort the list before printing
Date: Sun, 11 May 2014 14:20:37 +0600 [thread overview]
Message-ID: <1399796438-5495-7-git-send-email-shakursmullick@gmail.com> (raw)
In-Reply-To: <1399796438-5495-1-git-send-email-shakursmullick@gmail.com>
---
libsmartcols/src/table_print.c | 35 +++++++++++++++++++++++++++++++----
1 file changed, 31 insertions(+), 4 deletions(-)
diff --git a/libsmartcols/src/table_print.c b/libsmartcols/src/table_print.c
index 2942053..44c4525 100644
--- a/libsmartcols/src/table_print.c
+++ b/libsmartcols/src/table_print.c
@@ -20,6 +20,7 @@
#include <string.h>
#include <termios.h>
#include <ctype.h>
+#include <list.h>
#include "nls.h"
#include "mbsalign.h"
@@ -27,6 +28,7 @@
#include "ttyutils.h"
#include "carefulputc.h"
#include "smartcolsP.h"
+#include "strutils.h"
/* This is private struct to work with output data */
struct libscols_buffer {
@@ -38,6 +40,8 @@ struct libscols_buffer {
size_t art_idx; /* begin of the tree ascii art or zero */
};
+static uint sq;
+
static struct libscols_buffer *new_buffer(size_t sz)
{
struct libscols_buffer *buf = malloc(sz + sizeof(struct libscols_buffer));
@@ -694,7 +698,22 @@ static size_t strlen_line(struct libscols_line *ln)
return sz;
}
-
+int comparison_func(struct list_head *a, struct list_head *b, void *data)
+{
+ struct libscols_column *cl;
+ struct libscols_line *ra, *rb;
+ struct libscols_cell *ca, *cb;
+
+ cl = (struct libscols_column *)(data);
+
+ ra = list_entry(a, struct libscols_line, ln_lines);
+ rb = list_entry(b, struct libscols_line, ln_lines);
+
+ ca = scols_line_get_cell(ra, cl->seqnum);
+ cb = scols_line_get_cell(rb, cl->seqnum);
+
+ return cl->compar(ca, cb, NULL);
+}
/**
* scols_print_table:
@@ -709,9 +728,12 @@ int scols_print_table(struct libscols_table *tb)
int rc = 0;
size_t bufsz;
struct libscols_line *ln;
+ struct libscols_column *cl;
struct libscols_iter itr;
struct libscols_buffer *buf;
-
+ struct list_head *p;
+ char *sdata;
+
assert(tb);
if (!tb)
return -1;
@@ -742,10 +764,15 @@ int scols_print_table(struct libscols_table *tb)
rc = recount_widths(tb, buf);
if (scols_table_is_tree(tb))
- rc = print_tree(tb, buf);
+ rc = print_tree(tb, buf);
+ else if (!scols_table_get_key_column(tb))
+ rc = print_table(tb, buf);
else
+ {
+ cl = scols_table_get_key_column(tb);
+ list_sort(&tb->tb_lines, comparison_func, cl);
rc = print_table(tb, buf);
-
+ }
free_buffer(buf);
return rc;
}
--
1.8.3.2
next prev parent reply other threads:[~2014-05-11 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 8:20 [PATCH v2 1/8] libsmartcols/src/libsmartcols.h.in: add library functions Shakur Shams Mullick
2014-05-11 8:20 ` [PATCH v2 2/8] libsmartcols/src/libsmartcols.sym: add symbols Shakur Shams Mullick
2014-05-11 8:20 ` [PATCH v2 3/8] libsmartcols/src/smartcolsP.h: add new field to struct libscols_table Shakur Shams Mullick
2014-05-11 8:20 ` [PATCH 4/8] libsmartcols/src/cell.c: add two functions to compare number and string cells Shakur Shams Mullick
2014-05-12 12:37 ` Karel Zak
2014-05-11 8:20 ` [PATCH 5/8] libsmartcols/src/column.c: add function to set comparison function scols_column_set_sortcmp() sets the cell comparison function to use Shakur Shams Mullick
2014-05-11 8:20 ` [PATCH v2 6/8] libsmartcols/src/table.c: set and get key column to use for sorting scols_table_set_key_column() sets the column to use scols_table_get_key_column() returns the column being used Shakur Shams Mullick
2014-05-11 8:20 ` Shakur Shams Mullick [this message]
2014-05-12 12:43 ` [PATCH v2 7/8] libsmartcols/src/table_print.c: sort the list before printing Karel Zak
2014-05-12 17:22 ` shams
2014-05-11 8:20 ` [PATCH v2 8/8] misc-utils/lsblk.c: adds sorting support for lsblk Shakur Shams Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399796438-5495-7-git-send-email-shakursmullick@gmail.com \
--to=shakursmullick@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox