Re: [PATCH 11/17] setterm: correct usage() bright color argument

Karel Zak
2014-05-19T09:57:20Z

On Sun, May 18, 2014 at 03:05:35PM +0100, Sami Kerola wrote:
> fputs(_(" -foreground <default|black|blue|cyan|green|magenta|red|white|yellow>\n"), out);
> fputs(_(" -background <default|black|blue|cyan|green|magenta|red|white|yellow>\n"), out);
> - fputs(_(" -ulcolor <black|blue|bright|cyan|green|grey|magenta|red|white|yellow>\n"), out);
> - fputs(_(" -ulcolor <black|blue|bright|cyan|green|grey|magenta|red|white|yellow>\n"), out);
> - fputs(_(" -hbcolor <black|blue|bright|cyan|green|grey|magenta|red|white|yellow>\n"), out);
> - fputs(_(" -hbcolor <black|blue|bright|cyan|green|grey|magenta|red|white|yellow>\n"), out);
> + fputs(_(" -ulcolor <bright> <black|blue|cyan|green|grey|magenta|red|white|yellow>\n"), out);
> + fputs(_(" -ulcolor <bright> <black|blue|cyan|green|grey|magenta|red|white|yellow>\n"), out);
> + fputs(_(" -hbcolor <bright> <black|blue|cyan|green|grey|magenta|red|white|yellow>\n"), out);
> + fputs(_(" -hbcolor <bright> <black|blue|cyan|green|grey|magenta|red|white|yellow>\n"), out);

too many duplicate information, it would be better to use

_(" -foreground <default>|<color>\n")
...
_(" -hbcolor <bright> <color>\n")

and describe below in usage():

_(" <color> means black, blue, ...")

Karel

--
Karel Zak <kzak@redhat.com>