Re: [PATCH 1/4] setterm: add usage() descriptions

[Benno Schulenberg <bensberg@justemail.net>]

Hi Sami,

On Sat, May 24, 2014, at 13:08, Sami Kerola wrote:
> +	fputs(_(" --inversescreen <on|off>          inverse foreground and background colors\n"), out);

s/inverse/swap/
s/colors/colors for the whole screen/

And all these <on|off> should be [on|off], like in the man page,
as they are literal arguments and optional.

> +	fputs(_(" --foreground    <default|color>   set foreground color\n"), out);

default|<color>

> +	fputs(_(" --reverse       <on|off>          reverse all output options\n"), out);

Hm?  Shouldn't that be "set reverse video"?
Or maybe "swap foreground and background colors from here"?
It doesn't invert brightness or other attributes.

> +	fputs(_(" --clear         <all|rest>        clear screen and set cursor position\n"), out);

[all|rest]

> +	fputs(_(" --regtabs       <1-160>           set default tab stop position\n"), out);

To be consistent this should be "--regtabs <number>", and then add that
<number> can be 1..160.  But that loses conciseness.

> +	fputs(_(" --blank         <0-60|force|poke> set inactivity interval\n"), out);

--blank  [<number>|force|poke]
and <number> can be 1..60 (minutes)

Benno

-- 
http://www.fastmail.fm - Send your email first class