util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] textual: fix the usage message of kill
@ 2014-07-07 20:34 Benno Schulenberg
  2014-07-09 13:31 ` Benno Schulenberg
  0 siblings, 1 reply; 2+ messages in thread
From: Benno Schulenberg @ 2014-07-07 20:34 UTC (permalink / raw)
  To: util-linux

Using angular brackets around each individual argument, indenting a
continuation line, not using a space before =, and the argument of
--queue is a number (an element of data), not a signal.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
---
 misc-utils/kill.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/misc-utils/kill.c b/misc-utils/kill.c
index 5d2f27d..f1c734c 100644
--- a/misc-utils/kill.c
+++ b/misc-utils/kill.c
@@ -303,17 +303,17 @@ static int arg_to_signum(char *arg, int maskbit)
 static void __attribute__((__noreturn__)) usage(FILE *out)
 {
 	fputs(USAGE_HEADER, out);
-	fprintf(out, _(" %s [options] <pid|name>...\n"), program_invocation_short_name);
+	fprintf(out, _(" %s [options] <pid>|<name>...\n"), program_invocation_short_name);
 
 	fputs(USAGE_OPTIONS, out);
 	fputs(_(" -a, --all              do not restrict the name-to-pid conversion to processes\n"
-		"                        with the same uid as the present process\n"), out);
-	fputs(_(" -s, --signal <sig>     send specified signal\n"), out);
+		"                          with the same uid as the present process\n"), out);
+	fputs(_(" -s, --signal <signal>  send this <signal> instead of SIGTERM\n"), out);
 #ifdef HAVE_SIGQUEUE
-	fputs(_(" -q, --queue <sig>      use sigqueue(2) rather than kill(2)\n"), out);
+	fputs(_(" -q, --queue <number>   use sigqueue(2), not kill(2), and pass <number> as data\n"), out);
 #endif
 	fputs(_(" -p, --pid              print pids without signaling them\n"), out);
-	fputs(_(" -l, --list [=<signal>] list signal names, or convert one to a name\n"), out);
+	fputs(_(" -l, --list[=<signal>]  list signal names, or convert one to a name\n"), out);
 	fputs(_(" -L, --table            list signal names and numbers\n"), out);
 	fputs(_("     --verbose          print pids that will be signaled\n"), out);
 
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] textual: fix the usage message of kill
  2014-07-07 20:34 [PATCH] textual: fix the usage message of kill Benno Schulenberg
@ 2014-07-09 13:31 ` Benno Schulenberg
  0 siblings, 0 replies; 2+ messages in thread
From: Benno Schulenberg @ 2014-07-09 13:31 UTC (permalink / raw)
  To: Benno Schulenberg; +Cc: Util-Linux


On Mon, Jul 7, 2014, at 22:34, Benno Schulenberg wrote:
>  misc-utils/kill.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

Superseded by a later patch.

Benno

-- 
http://www.fastmail.fm - Or how I learned to stop worrying and
                          love email again


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-09 13:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-07 20:34 [PATCH] textual: fix the usage message of kill Benno Schulenberg
2014-07-09 13:31 ` Benno Schulenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).