From: Andreas Henriksson <andreas@fatal.se>
To: util-linux@vger.kernel.org
Cc: Andreas Henriksson <andreas@fatal.se>
Subject: [PATCH] libmount/buildsys: move SELINUX_LIBS to LDFLAGS
Date: Sat, 2 Aug 2014 22:11:01 +0200 [thread overview]
Message-ID: <1407010261-17305-1-git-send-email-andreas@fatal.se> (raw)
According to a bug report filed in the Debian bug tracking system
an unknown version of the package failed to cross-build because of
the -lfoo flags for SELinux being placed in LIBADD rather then LDFLAGS.
The build system still looks similar in this regard so it's possible
the problem still remains and hopefully this change should make things
more correct even if I still don't know if it solves the entire problem.
Reported-by: YunQiang Su <wzssyqa@gmail.com>
Addresses-Debian-Bug: #721431
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
libmount/src/Makemodule.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libmount/src/Makemodule.am b/libmount/src/Makemodule.am
index 54ab51d..afe5cfa 100644
--- a/libmount/src/Makemodule.am
+++ b/libmount/src/Makemodule.am
@@ -30,7 +30,7 @@ libmount_la_SOURCES = \
nodist_libmount_la_SOURCES = libmount/src/mountP.h
-libmount_la_LIBADD = libcommon.la libblkid.la $(SELINUX_LIBS)
+libmount_la_LIBADD = libcommon.la libblkid.la
libmount_la_CFLAGS = \
$(SOLIB_CFLAGS) \
@@ -46,6 +46,7 @@ libmount_la_DEPENDENCIES = \
libmount_la_LDFLAGS = \
$(SOLIB_LDFLAGS) \
+ $(SELINUX_LIBS) \
-Wl,--version-script=$(top_srcdir)/libmount/src/libmount.sym \
-version-info $(LIBMOUNT_VERSION_INFO)
--
2.0.1
next reply other threads:[~2014-08-02 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 20:11 Andreas Henriksson [this message]
2014-08-03 13:34 ` [PATCH] libmount/buildsys: move SELINUX_LIBS to LDFLAGS Mike Frysinger
2014-08-03 20:23 ` Andreas Henriksson
2014-08-04 7:40 ` Mike Frysinger
2014-08-04 9:49 ` Andreas Henriksson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407010261-17305-1-git-send-email-andreas@fatal.se \
--to=andreas@fatal.se \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).