* what precisely is partition_entry_lba?
@ 2014-09-22 19:44 Benno Schulenberg
2014-10-01 7:59 ` Karel Zak
0 siblings, 1 reply; 3+ messages in thread
From: Benno Schulenberg @ 2014-09-22 19:44 UTC (permalink / raw)
To: Util-Linux
Hi,
In libfdisk/src/gpt.c the function gpt_list_disklabel() prints
a GPT header, and one of the things it prints says:
_("Partitions entries LBA: %ju"), h->partition_entry_lba
In the struct this variable is described as:
uint64_t partition_entry_lba; /* stat LBA of the partition entry array */
This doesn't make sense to me. Shouldn't this say something
like "Starting block of the array of partition entries" instead?
All this use of 'lba' is confusing to me, as it stands for
"logical block addressing", and what seems to be meant
is simply "logical block" or "logical block number". No?
Benno
--
http://www.fastmail.fm - The way an email service should be
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: what precisely is partition_entry_lba?
2014-09-22 19:44 what precisely is partition_entry_lba? Benno Schulenberg
@ 2014-10-01 7:59 ` Karel Zak
2014-10-01 19:34 ` Benno Schulenberg
0 siblings, 1 reply; 3+ messages in thread
From: Karel Zak @ 2014-10-01 7:59 UTC (permalink / raw)
To: Benno Schulenberg; +Cc: Util-Linux
On Mon, Sep 22, 2014 at 09:44:05PM +0200, Benno Schulenberg wrote:
>
> Hi,
>
> In libfdisk/src/gpt.c the function gpt_list_disklabel() prints
> a GPT header, and one of the things it prints says:
>
> _("Partitions entries LBA: %ju"), h->partition_entry_lba
>
> In the struct this variable is described as:
>
> uint64_t partition_entry_lba; /* stat LBA of the partition entry array */
>
> This doesn't make sense to me. Shouldn't this say something
> like "Starting block of the array of partition entries" instead?
EFI standard:
"The start of the GPT Partition Entry Array is located at the LBA
indicated by the Partition Entry LBA field."
> All this use of 'lba' is confusing to me, as it stands for
> "logical block addressing", and what seems to be meant
> is simply "logical block" or "logical block number". No?
Well, "LBA" is usually used as unit (especially in storage slang).
Don't think about it as about abbreviation :-)
IMHO the fdisk message "Partitions entries LBA: %ju" is fine, it's
better to follow commonly terminology.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: what precisely is partition_entry_lba?
2014-10-01 7:59 ` Karel Zak
@ 2014-10-01 19:34 ` Benno Schulenberg
0 siblings, 0 replies; 3+ messages in thread
From: Benno Schulenberg @ 2014-10-01 19:34 UTC (permalink / raw)
To: Karel Zak; +Cc: Util-Linux
On Wed, Oct 1, 2014, at 09:59, Karel Zak wrote:
> On Mon, Sep 22, 2014 at 09:44:05PM +0200, Benno Schulenberg wrote:
> > uint64_t partition_entry_lba; /* stat LBA of the partition entry array */
> >
> > This doesn't make sense to me. Shouldn't this say something
> > like "Starting block of the array of partition entries" instead?
>
> EFI standard:
>
> "The start of the GPT Partition Entry Array is located at the LBA
> indicated by the Partition Entry LBA field."
Okay. Then at least the relevant comment needs to be typo-fixed.
(Upcoming patch will do also that.)
> > All this use of 'lba' is confusing to me, as it stands for
> > "logical block addressing", and what seems to be meant
> > is simply "logical block" or "logical block number". No?
>
> Well, "LBA" is usually used as unit (especially in storage slang).
> Don't think about it as about abbreviation :-)
I can't -- my brain always auto-expands abbrevs. :)
Well, I will just have to expand it as "Logical Block Address",
even though the word "Address" is completely superfluous.
> IMHO the fdisk message "Partitions entries LBA: %ju" is fine,
Not quite. It would have to be either "Partitions entry" (where
one entry contains several paritions) or "Partition entries), where
each entry contains one partition, which is of course the case);
"Partitions entries" is nonsense in English. Upcoming patch
makes the correction.
Benno
--
http://www.fastmail.fm - Access all of your messages and folders
wherever you are
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-01 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-22 19:44 what precisely is partition_entry_lba? Benno Schulenberg
2014-10-01 7:59 ` Karel Zak
2014-10-01 19:34 ` Benno Schulenberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).