util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benno Schulenberg <bensberg@justemail.net>
To: "Ville Skyttä" <ville.skytta@iki.fi>
Cc: "Util-Linux" <util-linux@vger.kernel.org>
Subject: Re: [PATCH] Spelling fixes
Date: Sun, 16 Nov 2014 12:40:13 +0100	[thread overview]
Message-ID: <1416138013.3540405.191555165.2F640DB3@webmail.messagingengine.com> (raw)
In-Reply-To: <1416084103-15931-1-git-send-email-ville.skytta@iki.fi>


On Sat, Nov 15, 2014, at 21:41, Ville Skyttä wrote:
> --- a/Documentation/releases/v2.25-ReleaseNotes
> +++ b/Documentation/releases/v2.25-ReleaseNotes
> @@ -1146,7 +1146,7 @@ tests:
>     - allow to add or override test suite options  [Ruediger Meier]
>     - avoid executing dirname(1) command  [Sami Kerola]
>     - cal  do not let --week=<num> to adjust requested month  [Sami Kerola]
> -   - cal  take account week numbers when determing month lenght  [Sami Kerola]
> +   - cal  take account week numbers when determing month length  [Sami Kerola]

I don't think it's a good idea to spell-correct these automatically
generated release notes -- if anyone reads them, and they find
something they want to look, to see the diff, then their only option
is to search for the given commit message in 'git log -p'.  If this
string no longer matches...

But /if/ it is okay to make spelling fixes to the release notes, then
also s/determing/determining/, and s/take account week numbers/
take week numbers into account/.  Many of Sami's commit lines
would need to be tweaked -- sorry, Sami.  :)

Benno

-- 
http://www.fastmail.fm - Access your email from home and the web


  reply	other threads:[~2014-11-16 11:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 20:41 [PATCH] Spelling fixes Ville Skyttä
2014-11-16 11:40 ` Benno Schulenberg [this message]
2014-11-16 11:57   ` Sami Kerola
2014-11-18 13:00 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416138013.3540405.191555165.2F640DB3@webmail.messagingengine.com \
    --to=bensberg@justemail.net \
    --cc=util-linux@vger.kernel.org \
    --cc=ville.skytta@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).