Util-Linux package development
 help / color / mirror / Atom feed
From: Benno Schulenberg <bensberg@justemail.net>
To: Yuri Chornoivan <yurchor@gmail.com>
Cc: "Util-Linux" <util-linux@vger.kernel.org>,
	Yuri Chornoivan <yurchor@ukr.net>
Subject: Re: [PATCH] Fix various minor typos
Date: Sat, 24 Jan 2015 18:23:35 +0100	[thread overview]
Message-ID: <1422120215.1322663.218300697.5A4C9C5F@webmail.messagingengine.com> (raw)
In-Reply-To: <1422083931-24410-1-git-send-email-yurchor@ukr.net>


Hello Yuri,

On Sat, Jan 24, 2015, at 08:18, Yuri Chornoivan wrote:
> --- a/Documentation/releases/v2.25-ReleaseNotes
> +++ b/Documentation/releases/v2.25-ReleaseNotes
> @@ -203,7 +203,7 @@ cal:
>     - mention where Gregorian reformation happen in September 1752  [Sami Kerola]
>     - remove optional from short arg -w  [Tommi Kyntola]
>     - remove unnecessary static variables  [Sami Kerola]
> -   - remove unnused structure and definition  [Sami Kerola]
> +   - remove unused structure and definition  [Sami Kerola]

These lines were automatically generated from commit messages;
if you change them in the release notes, they cannot be used
anymore to find the corresponding commit.

All the other changes are good, except for this one:

> -			fdisk_warnx(cxt, _("unssuported GPT attribute bit '%s'"), p);
> +			fdisk_warnx(cxt, _("unsuported GPT attribute bit '%s'"), p);

You missed the single that should be a double p.
But I think you caught all the other typos.  :)

Some of them I already corrected in this patch:
http://www.spinics.net/lists/util-linux-ng/msg10888.html
If you exclude those from your patch, it will then apply after
mine without conflict.

Benno

-- 
http://www.fastmail.com - Email service worth paying for. Try it for free


  reply	other threads:[~2015-01-24 17:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24  7:18 [PATCH] Fix various minor typos Yuri Chornoivan
2015-01-24 17:23 ` Benno Schulenberg [this message]
2015-01-25  8:02   ` Yuri Chornoivan
2015-01-26 10:42 ` Karel Zak
2015-01-26 20:51   ` Benno Schulenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422120215.1322663.218300697.5A4C9C5F@webmail.messagingengine.com \
    --to=bensberg@justemail.net \
    --cc=util-linux@vger.kernel.org \
    --cc=yurchor@gmail.com \
    --cc=yurchor@ukr.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox