util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sami Kerola <kerolasa@iki.fi>,
	Marcel Holtmann <marcel@holtmann.org>,
	Tim Gardner <tim.gardner@canonical.com>,
	Karel Zak <kzak@redhat.com>
Cc: linux-wireless@vger.kernel.org, util-linux@vger.kernel.org
Subject: Re: rfkill(8) move and improvements
Date: Thu, 29 Jun 2017 16:04:00 +0200	[thread overview]
Message-ID: <1498745040.3141.6.camel@sipsolutions.net> (raw)
In-Reply-To: <alpine.LNX.2.20.1706251339500.25762@imuri> (sfid-20170625_150452_207599_1328128A)

Hi Sami, all,

> The otherday I ran powertop and it did rfkill to save battery, which
> was particularly annoying because I had not installed rfkill(8)
> package.  
> Fixing the immediate issue was relatively easy, but the ordeal made
> me wonder if this tool could be moved to a package that is installed
> by default to all systems, such as util-linux.

[...]

> What do you think, would the move and proposed updates be ok?

I can't say I mind, and most of your proposed changes seem sensible,
though I haven't reviewed them in enough detail to comment on them.
Something that caught my eye here was comparing a string to _("all")
which seems wrong, since that'd mean you'd have to type the translated
version even on the command line? That seems really awkward (to put it
charitably).

However, at the same time, I have very little desire to get involved
with util-linux as yet another project, so frankly I'd probably
continue to "maintain" the current rfkill tool - which really hasn't
changed in a very long time, and hope somebody else picks up
maintenance of rfkill included in util-linux.

johannes

  reply	other threads:[~2017-06-29 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25 13:04 rfkill(8) move and improvements Sami Kerola
2017-06-29 14:04 ` Johannes Berg [this message]
2017-06-29 21:23   ` Sami Kerola
2017-06-30  7:47     ` Karel Zak
2017-07-01  9:06       ` Sami Kerola
2017-08-30 19:40         ` Sami Kerola
2017-08-31  9:46           ` Karel Zak
2017-08-31  9:47           ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498745040.3141.6.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=kerolasa@iki.fi \
    --cc=kzak@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=tim.gardner@canonical.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).