From: <jgroves@micron.com>
To: Karel Zak <kzak@redhat.com>
Cc: <util-linux@vger.kernel.org>, <John@Groves.net>,
John Groves <jgroves@micron.com>
Subject: [PATCH v2 0/2] libblkid: recognize Micron mpool formatted devices
Date: Wed, 15 Nov 2017 18:48:09 -0600 [thread overview]
Message-ID: <1510793291-4771-1-git-send-email-jgroves@micron.com> (raw)
From: John Groves <jgroves@micron.com>
This patch adds libblkid recognition of Micron mpool formatted devices.
It also adds a very simple crc32c() function, for use by probe_mpool().
If there are objections to adding crc32c, I can re-submit without it, or
make it static for probe_mpool(). I would prefer not to go without crc32c
validation, because the only remaining check would be the magic number.
Review comments and/or questions still welcome.
Changes since v1:
* probe_mpool() no longer calls blkid_probe_set_value to set
VALID="yes"|"no". This was debug code that I had failed to excise
previously.
Thanks,
John Groves (2):
Add simple crc32c() function
Add support for Micron mpool formatted drives
include/crc32c.h | 9 +++
lib/Makemodule.am | 1 +
lib/crc32c.c | 102 +++++++++++++++++++++++++++++++++
libblkid/src/Makemodule.am | 1 +
libblkid/src/superblocks/mpool.c | 69 ++++++++++++++++++++++
libblkid/src/superblocks/superblocks.c | 3 +-
libblkid/src/superblocks/superblocks.h | 1 +
7 files changed, 185 insertions(+), 1 deletion(-)
create mode 100644 include/crc32c.h
create mode 100644 lib/crc32c.c
create mode 100644 libblkid/src/superblocks/mpool.c
--
2.9.3
next reply other threads:[~2017-11-16 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 0:48 jgroves [this message]
2017-11-16 0:48 ` [PATCH v2 1/2] Add simple crc32c() function jgroves
2017-11-16 0:48 ` [PATCH v2 2/2] Add support for Micron mpool formatted drives jgroves
2017-11-16 4:58 ` [PATCH v2 0/2] libblkid: recognize Micron mpool formatted devices John Groves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510793291-4771-1-git-send-email-jgroves@micron.com \
--to=jgroves@micron.com \
--cc=John@Groves.net \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).