From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 6/6] sfdisk: fix for data type mismatches
Date: Tue, 14 Jun 2011 13:29:19 +0200 [thread overview]
Message-ID: <20110614112919.GE14293@nb.net.home> (raw)
In-Reply-To: <1307387239-9022-7-git-send-email-kerolasa@iki.fi>
On Mon, Jun 06, 2011 at 09:07:19PM +0200, Sami Kerola wrote:
> + if ((unsigned long) pno+4 >= ARRAY_SIZE(z->partitions)) {
Why 'unsigned long'? I guess that ARRAY_SIZE returns size_t. Maybe it
would be better to use size_t for partno numbers rather than add the
cast.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-06-14 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 19:07 [PATCH 0/6] sfdisk: few maintenance patches Sami Kerola
2011-06-06 19:07 ` [PATCH 1/6] sfdisk: declare unused function attributes Sami Kerola
2011-06-06 19:07 ` [PATCH 2/6] sfdisk: help screen format Sami Kerola
2011-06-06 19:07 ` [PATCH 3/6] sfdisk: previously undocumented options to usage Sami Kerola
2011-06-06 19:07 ` [PATCH 4/6] docs: sfdisk manual update Sami Kerola
2011-06-06 19:07 ` [PATCH 5/6] sfdisk: fix implicit overflow Sami Kerola
2011-06-06 19:07 ` [PATCH 6/6] sfdisk: fix for data type mismatches Sami Kerola
2011-06-14 11:29 ` Karel Zak [this message]
2011-06-14 20:00 ` Sami Kerola
2011-06-29 10:50 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614112919.GE14293@nb.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox