From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: util-linux-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:29004 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755302Ab1FNLpj (ORCPT ); Tue, 14 Jun 2011 07:45:39 -0400 Date: Tue, 14 Jun 2011 13:45:34 +0200 From: Karel Zak To: Ludwig Nussel Cc: util-linux@vger.kernel.org Subject: Re: [PATCH] uuidgen: print warning if uuidd isn't running Message-ID: <20110614114534.GF14293@nb.net.home> References: <1307540101-6376-1-git-send-email-ludwig.nussel@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1307540101-6376-1-git-send-email-ludwig.nussel@suse.de> Sender: util-linux-owner@vger.kernel.org List-ID: On Wed, Jun 08, 2011 at 03:35:01PM +0200, Ludwig Nussel wrote: > --- > misc-utils/uuidgen.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/misc-utils/uuidgen.c b/misc-utils/uuidgen.c > index 3cf6ec9..47f8e8f 100644 > --- a/misc-utils/uuidgen.c > +++ b/misc-utils/uuidgen.c > @@ -59,7 +59,9 @@ main (int argc, char *argv[]) > > switch (do_type) { > case DO_TYPE_TIME: > - uuid_generate_time(uu); > + if (uuid_generate_time_safe(uu)) { > + fprintf(stderr, _("Warning: uuidd not running or not operational. Time based uuid may not be unique.\n")); IMHO this is overkill -- the uuidd is used very rarely (usually on large systems with SAP) and it's disabled by default in many distributions, but the uuidgen(1) util is available everywhere and used probably often used by admins/scripts. It would be better to add some WARNING section to the uuidgen(1) man page to inform users about the disadvantage. Karel -- Karel Zak http://karelzak.blogspot.com