From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] mkfs.minix: check for misalignment
Date: Mon, 27 Jun 2011 16:23:41 +0200 [thread overview]
Message-ID: <20110627142341.GB14747@nb.net.home> (raw)
In-Reply-To: <1308625906.3690.2.camel@offworld>
On Mon, Jun 20, 2011 at 11:11:46PM -0400, Davidlohr Bueso wrote:
> disk-utils/mkfs.minix.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
Applied with a small change, thanks.
> @@ -653,6 +653,11 @@ int main(int argc, char ** argv) {
> DEV = open(device_name,O_RDWR | O_EXCL);
> else
> DEV = open(device_name,O_RDWR);
> +
> + if (blkdev_is_misaligned(DEV))
> + warnx(_("warning: %s is misaligned"), device_name);
It makes sense for block devices only.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2011-06-27 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 3:11 [PATCH] mkfs.minix: check for misalignment Davidlohr Bueso
2011-06-27 14:23 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110627142341.GB14747@nb.net.home \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox