From: Karel Zak <kzak@redhat.com>
To: util-linux <util-linux@vger.kernel.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>
Subject: Re: [PATCH] umount: do not hang with disconnected NFS mounts
Date: Wed, 29 Jun 2011 11:12:50 +0200 [thread overview]
Message-ID: <20110629091250.GG6418@nb.net.home> (raw)
In-Reply-To: <20110629082408.GA27888@foxbat.suse.cz>
On Wed, Jun 29, 2011 at 10:24:09AM +0200, Petr Uzel wrote:
> Since util-linux commit f4612577c942a3683b97632ad0b49671897c2070,
> umount stat(2)s its argument to check whether it can be associated
> with some loop device. This could hang with broken NFS mounts.
>
> Fix by first checking mtab if umount's argument is mounted and only if
> we fail, check if there is a loop device associated.
>
> http://marc.info/?l=util-linux-ng&m=130924963804836&w=2
>
> Reported-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
> Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
> ---
> mount/umount.c | 42 ++++++++++++++++++++++--------------------
> 1 files changed, 22 insertions(+), 20 deletions(-)
Applied, thanks (also to Konstantin)!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2011-06-29 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 8:24 [PATCH] umount: do not hang with disconnected NFS mounts Petr Uzel
2011-06-29 9:12 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629091250.GG6418@nb.net.home \
--to=kzak@redhat.com \
--cc=khlebnikov@openvz.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox