From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 4/4] script: remove magic constants and a type mismatch fix
Date: Wed, 29 Jun 2011 11:44:51 +0200 [thread overview]
Message-ID: <20110629094451.GK6418@nb.net.home> (raw)
In-Reply-To: <1309257806-1418-4-git-send-email-kerolasa@iki.fi>
On Tue, Jun 28, 2011 at 12:43:26PM +0200, Sami Kerola wrote:
> term-utils/script.c | 68 ++++++++++++++++++++++++++------------------------
> 1 files changed, 35 insertions(+), 33 deletions(-)
Applied.
>> void
> fail() {
>
> - kill(0, SIGTERM);
> + kill(getpid(), SIGTERM);
> done();
> }
I think we want to use zero rather than getpid()...
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-06-29 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 10:43 [PATCH 1/4] script: option --force added Sami Kerola
2011-06-28 10:43 ` [PATCH 2/4] script: remove unnecessary void casting Sami Kerola
2011-06-29 9:35 ` Karel Zak
2011-06-28 10:43 ` [PATCH 3/4] script: include-what-you-use header check Sami Kerola
2011-06-29 9:35 ` Karel Zak
2011-06-28 10:43 ` [PATCH 4/4] script: remove magic constants and a type mismatch fix Sami Kerola
2011-06-29 9:44 ` Karel Zak [this message]
2011-06-29 9:34 ` [PATCH 1/4] script: option --force added Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629094451.GK6418@nb.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox