From: Karel Zak <kzak@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>,
util-linux@vger.kernel.org
Subject: Re: [PATCH] Don't try to chgrp write or wall if they are not built
Date: Thu, 30 Jun 2011 12:33:25 +0200 [thread overview]
Message-ID: <20110630103325.GN6418@nb.net.home> (raw)
In-Reply-To: <20110630085327.GA8274@aepfle.de>
On Thu, Jun 30, 2011 at 10:53:27AM +0200, Olaf Hering wrote:
> On Thu, Jun 30, Marc-Antoine Perennou wrote:
>
> > Fix regression from commit 4aa9d65bfa76afd0d886ca410ae83428a490d4ea
> >
> > Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
> > ---
> > term-utils/Makefile.am | 10 ++++++++--
>
> > - chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
> > $(DESTDIR)$(usrbin_execdir)/write
> > - chmod g+s $(DESTDIR)$(usrbin_execdir)/wall
> > $(DESTDIR)$(usrbin_execdir)/write
> > +if BUILD_WALL
> > + chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
>
> This is wrong and should part of the packaging system, not part of make
> install. The userid building util-linux is not neccessary part of the
> tty group.
Why do you expect that everyone uses any packaging system? The "make
install" result should be usable. Note that this all is controlled by
--disable-makeinstall-chown and --disable-makeinstall-setuid options.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-06-30 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 0:26 [PATCH] Don't try to chgrp write or wall if they are not built Marc-Antoine Perennou
2011-06-30 8:53 ` Olaf Hering
2011-06-30 10:33 ` Karel Zak [this message]
2011-06-30 11:00 ` Olaf Hering
2011-07-11 9:54 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630103325.GN6418@nb.net.home \
--to=kzak@redhat.com \
--cc=Marc-Antoine@Perennou.com \
--cc=olaf@aepfle.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox