From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 2/3] mkfs.minix: add minix v3 support
Date: Mon, 11 Jul 2011 10:51:29 +0200 [thread overview]
Message-ID: <20110711085129.GC5214@nb.net.home> (raw)
In-Reply-To: <1309368495.3162.4.camel@offbook>
On Wed, Jun 29, 2011 at 01:28:15PM -0400, Davidlohr Bueso wrote:
> disk-utils/Makefile.am | 2 +-
> disk-utils/mkfs.minix.c | 142 ++++++++++++++++++++++++++++++++++++-----------
> 2 files changed, 110 insertions(+), 34 deletions(-)
Applied with some changes, thanks.
> +static int *super_set_state_ptr(void)
> +{
> + switch (fs_version) {
> + case 3:
> + Super3.s_state |= MINIX_VALID_FS;
> + Super3.s_state &= ~MINIX_ERROR_FS;
> + break;
> + default:
> + Super.s_state |= MINIX_VALID_FS;
> + Super.s_state &= ~MINIX_ERROR_FS;
> + break;
> + }
[...]
> + int *state = super_set_state_ptr();
This does not make sense. The function does not return anything and
the 'int *state' is not used. Fixed (but not tested), see the git
repository.
It would be nice to have tests/ts/minix/mkfs-v{2,3} ;-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2011-07-11 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 17:28 [PATCH 2/3] mkfs.minix: add minix v3 support Davidlohr Bueso
2011-07-11 8:51 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711085129.GC5214@nb.net.home \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox