From: Karel Zak <kzak@redhat.com>
To: giulioo@pobox.com
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] sfdisk: make some tests conditional to !Linux
Date: Mon, 22 Aug 2011 10:32:06 +0200 [thread overview]
Message-ID: <20110822083206.GA20457@nb.net.home> (raw)
In-Reply-To: <20110818073019.B70AFF815@i3.golden.dom>
On Thu, Aug 18, 2011 at 09:30:30AM +0200, Giulio wrote:
> + if (!chs_ok(b, PNO(p), _("start")) && !Linux)
[...]
> + if (!chs_ok(b, PNO(p), _("end")) && !Linux)
would be better to use
if (!Linux && chs_ok(b, PNO(p), ....)
so the chs_ok() will not called on Linux at all?
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-08-22 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 7:30 [PATCH] sfdisk: make some tests conditional to !Linux Giulio
2011-08-22 8:32 ` Karel Zak [this message]
2011-08-22 18:45 ` Giulio Orsero
2011-08-22 18:46 ` Giulio Orsero
2011-08-23 10:21 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822083206.GA20457@nb.net.home \
--to=kzak@redhat.com \
--cc=giulioo@pobox.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox