From: Karel Zak <kzak@redhat.com>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: util-linux@vger.kernel.org, kerolasa@iki.fi
Subject: Re: [PATCH] script.c: drop libintl.h include
Date: Wed, 7 Sep 2011 16:32:13 +0200 [thread overview]
Message-ID: <20110907143213.GA4204@nb> (raw)
In-Reply-To: <877h5klgcs.fsf@macbook.be.48ers.dk>
On Wed, Sep 07, 2011 at 01:52:19PM +0200, Peter Korsgaard wrote:
> >>>>> "Karel" == Karel Zak <kzak@redhat.com> writes:
>
> Karel> On Mon, Sep 05, 2011 at 10:02:55PM +0200, Peter Korsgaard wrote:
> >> Commit 8fb810ff26 (script: include-what-you-use header check) added a
> >> <libintl.h> #include, which isn't needed as nls.h includes it (if
> >> enabled) - But worse, breaks the build for systems without libintl.h
> >> (like some uClibc configurations).
>
> Karel> Already fixed by patch from Natanael Copa.
>
> Ahh, didn't notice it because of the kernel.org issue. While that patch
> also fixes the problem, it is more complicated than needed as nls.h
> already includes libintl.h - E.G. the explicit include can just be
> removed.
Yes, good point. Fixed.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2011-09-07 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 20:02 [PATCH] script.c: drop libintl.h include Peter Korsgaard
2011-09-07 5:33 ` Karel Zak
2011-09-07 11:52 ` Peter Korsgaard
2011-09-07 14:32 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907143213.GA4204@nb \
--to=kzak@redhat.com \
--cc=jacmet@sunsite.dk \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox