From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] mount: use common libs
Date: Wed, 14 Sep 2011 16:45:39 +0200 [thread overview]
Message-ID: <20110914144539.GA1829@nb.net.home> (raw)
In-Reply-To: <1315926455.3703.2.camel@offbook>
On Tue, Sep 13, 2011 at 12:07:35PM -0300, Davidlohr Bueso wrote:
> --- a/mount/devname.c
> +++ b/mount/devname.c
> @@ -2,6 +2,7 @@
>
> #include "devname.h"
> #include "sundries.h" /* for xstrdup */
> +#include "xalloc.h"
It would be better to include xalloc.h in sunders.h only.
> -static void
> -die_if_null(void *t) {
> - if (t == NULL)
> - die(EX_SYSERR, _("not enough memory"));
^^^^^^^^
> -}
it means that you have to use:
#define XALLOC_EXIT_CODE EX_SYSERR
#include "xalloc.h"
to keep it backwardly compatible.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-09-14 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 15:07 [PATCH] mount: use common libs Davidlohr Bueso
2011-09-14 14:45 ` Karel Zak [this message]
2011-09-14 17:06 ` Davidlohr Bueso
2011-09-14 18:07 ` Davidlohr Bueso
2011-09-27 10:51 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110914144539.GA1829@nb.net.home \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).