From: "Ted Ts'o" <tytso@mit.edu>
To: Tim Pepper <tpepper@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: libuuid clock.txt fd leaks
Date: Wed, 21 Sep 2011 18:24:12 -0400 [thread overview]
Message-ID: <20110921222412.GA6654@thunk.org> (raw)
In-Reply-To: <CAHuv5Kn4eOjsm9JORpjWJjD15vUEmrOx5K_xzU+wie8f4Cx8AA@mail.gmail.com>
On Wed, Sep 21, 2011 at 03:02:48PM -0700, Tim Pepper wrote:
> Is the original optimization really needed? If not you avoid the whole
> problem...no static, no TLS, no fd left open.
> I wonder who would whinge on performance if the open/close simply
> happened everytime? Ie: remove initial state_fd=-2 and its associated
> special casing.
There are programs out there that generate literally tens of thousands
of UUID's per second. One example of such a program filed high
priority bugs with both RHEL and SLES because it wasn't fast enough
and the uuid library was slowing down the setup time of an
commercially important Enterprise Resource Planning product by hours.
The reason why I implemented uuidd was specifically to help out this
product and this company. Partially because it was economically
important to Red Hat, SLES, and IBM (who was my employer at the time),
and partially because I had a soft spot for this company, to which I had
helped add Kerberos authentication and was very supportive of Linux in
the mid 1990's, before Linux had been discovered by big business.
But yeah, there are people and companies who really care about
libuuid's performance.
- Ted
next prev parent reply other threads:[~2011-09-21 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 16:58 libuuid clock.txt fd leaks Tim Pepper
2011-09-21 20:26 ` Ted Ts'o
2011-09-21 21:15 ` Ted Ts'o
2011-09-21 22:02 ` Tim Pepper
2011-09-21 22:19 ` Tim Pepper
2011-09-21 22:24 ` Ted Ts'o [this message]
2011-09-21 22:32 ` Tim Pepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921222412.GA6654@thunk.org \
--to=tytso@mit.edu \
--cc=tpepper@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox