From: Karel Zak <kzak@redhat.com>
To: Petr Uzel <petr.uzel@suse.cz>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 0/7] sfdisk improvements
Date: Tue, 27 Sep 2011 15:35:52 +0200 [thread overview]
Message-ID: <20110927133552.GD1982@nb.net.home> (raw)
In-Reply-To: <1316438955-20790-1-git-send-email-petr.uzel@suse.cz>
On Mon, Sep 19, 2011 at 03:29:08PM +0200, Petr Uzel wrote:
> Third one makes sfdisk not to issue a fatal warning (overridable, though),
> if the partition does not start/end on the cylinder boundary and
> the unit specified is other than cylinders. These days,
> we shouldn't care about the CHS that much IMO...
Right, see also cc393e381def1540db7b1273dde9410bea616b22. Giulio has
added some improvements for -L (Linux) option to disable some silly
tests.
> I decided to use unsigned long long to represent the 64-bit integers,
> which might not be the best choice (maybe we should use off_t or uint64_t
> instead??). Comments are welcomed.
Well, "unsigned long long" is horribly long, but probably good enough
for now (as we already using this type in fdisk.c).
The real solution is to start to work on a new fdisks...
Applied, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2011-09-27 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 13:29 [PATCH 0/7] sfdisk improvements Petr Uzel
2011-09-19 13:29 ` [PATCH 1/7] sfdisk: file descriptor is of int type Petr Uzel
2011-09-19 13:29 ` [PATCH 2/7] sfdisk: fix weird indentation in msdos_partition() Petr Uzel
2011-09-19 13:29 ` [PATCH 3/7] sfdisk: make the cylinder boundary check less fatal Petr Uzel
2011-09-19 13:29 ` [PATCH 4/7] sfdisk: get_disksize() returns long long Petr Uzel
2011-09-19 13:29 ` [PATCH 5/7] sfdisk: introduce get_ull() function Petr Uzel
2011-09-19 13:29 ` [PATCH 6/7] sfdisk: use unsigned long long to internally represent sector number Petr Uzel
2011-09-19 13:29 ` [PATCH 7/7] sfdisk: warn if partition exceeds partition table limits Petr Uzel
2011-09-27 13:35 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927133552.GD1982@nb.net.home \
--to=kzak@redhat.com \
--cc=petr.uzel@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).