From: Karel Zak <kzak@redhat.com>
To: Francesco Cosoleto <cosoleto@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 1/3] ipcrm: add static keyword to some functions
Date: Thu, 29 Sep 2011 00:40:25 +0200 [thread overview]
Message-ID: <20110928224025.GI19994@nb.net.home> (raw)
In-Reply-To: <1317219931-20496-1-git-send-email-cosoleto@gmail.com>
On Wed, Sep 28, 2011 at 04:25:29PM +0200, Francesco Cosoleto wrote:
> Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
> ---
> sys-utils/ipcrm.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
On Wed, Sep 28, 2011 at 04:25:30PM +0200, Francesco Cosoleto wrote:
> Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
> ---
> sys-utils/ipcrm.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
On Wed, Sep 28, 2011 at 04:25:31PM +0200, Francesco Cosoleto wrote:
> This makes error messages print 'id' instead of 'key' using id options.
>
> Signed-off-by: Francesco Cosoleto <cosoleto@gmail.com>
> ---
> sys-utils/ipcrm.c | 23 ++++++++---------------
> 1 files changed, 8 insertions(+), 15 deletions(-)
All applied. Thanks for review!
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-09-28 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 14:25 [PATCH 1/3] ipcrm: add static keyword to some functions Francesco Cosoleto
2011-09-28 14:25 ` [PATCH 2/3] ipcrm: use ternary operator in "(key|id) failed" message Francesco Cosoleto
2011-09-28 22:40 ` Karel Zak [this message]
2011-09-28 14:25 ` [PATCH 3/3] ipcrm: fix wrong subject in error messages for -m, -q, -s id options Francesco Cosoleto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110928224025.GI19994@nb.net.home \
--to=kzak@redhat.com \
--cc=cosoleto@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).