Re: [PATCH 3/6] lscpu: change column names back to mixed case

[Heiko Carstens <heiko.carstens@de.ibm.com>]

On Mon, Oct 10, 2011 at 12:59:45PM +0200, Karel Zak wrote:
> On Mon, Oct 10, 2011 at 10:59:41AM +0200, Heiko Carstens wrote:
> > Commit b9d18bc3 "lscpu: add column names to --help" changed all column names
> > to upper case only and printed the column names for the parsable output in
> > lower case.
> 
> This is bug. Sorry.
> 
> > However current behaviour was that for the parsable output the column names
> > were printed in mixed case. The change might break existing other tools and
> > breaks also the util-linux internal lscpu tests.
> > So revert part of the above commit and restore the old behaviour.
> 
> It would be better to fix the code (upper case for the first letter)
> than revert the patch.

I wanted to... but there is the special case "CPU" which was all upper case
already before :/
And adding special case handling in code sucks a bit, no?

> I think that we want to use the same concept for column names in all
> utils (findmnt, lsblk, ...) where we use upper case in help, man pages
> and all outputs. 
> 
> The old parsable output is exception, the new -e output should be
> compatible with the rest of util-linux.
> 
> I will fix it. Thanks.

Ok, will you update the (new) lscpu man page needs to be changed as well then.
I can send an update if you want.

Thanks,
Heiko