From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: util-linux-owner@vger.kernel.org Received: from mtagate2.uk.ibm.com ([194.196.100.162]:53360 "EHLO mtagate2.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753546Ab1JJLNY (ORCPT ); Mon, 10 Oct 2011 07:13:24 -0400 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p9ABDMUk031970 for ; Mon, 10 Oct 2011 11:13:22 GMT Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9ABDM3d2351254 for ; Mon, 10 Oct 2011 12:13:22 +0100 Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9ABDMn6009530 for ; Mon, 10 Oct 2011 12:13:22 +0100 Date: Mon, 10 Oct 2011 13:13:21 +0200 From: Heiko Carstens To: Karel Zak Cc: util-linux@vger.kernel.org Subject: Re: [PATCH 3/6] lscpu: change column names back to mixed case Message-ID: <20111010111321.GA6695@osiris.boeblingen.de.ibm.com> References: <1318237184-6616-1-git-send-email-heiko.carstens@de.ibm.com> <1318237184-6616-4-git-send-email-heiko.carstens@de.ibm.com> <20111010105945.GA17242@nb.net.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20111010105945.GA17242@nb.net.home> Sender: util-linux-owner@vger.kernel.org List-ID: On Mon, Oct 10, 2011 at 12:59:45PM +0200, Karel Zak wrote: > On Mon, Oct 10, 2011 at 10:59:41AM +0200, Heiko Carstens wrote: > > Commit b9d18bc3 "lscpu: add column names to --help" changed all column names > > to upper case only and printed the column names for the parsable output in > > lower case. > > This is bug. Sorry. > > > However current behaviour was that for the parsable output the column names > > were printed in mixed case. The change might break existing other tools and > > breaks also the util-linux internal lscpu tests. > > So revert part of the above commit and restore the old behaviour. > > It would be better to fix the code (upper case for the first letter) > than revert the patch. I wanted to... but there is the special case "CPU" which was all upper case already before :/ And adding special case handling in code sucks a bit, no? > I think that we want to use the same concept for column names in all > utils (findmnt, lsblk, ...) where we use upper case in help, man pages > and all outputs. > > The old parsable output is exception, the new -e output should be > compatible with the rest of util-linux. > > I will fix it. Thanks. Ok, will you update the (new) lscpu man page needs to be changed as well then. I can send an update if you want. Thanks, Heiko