From: Karel Zak <kzak@redhat.com>
To: Dave Reisner <d@falconindy.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] mountpoint: refactor exit path
Date: Tue, 11 Oct 2011 01:05:58 +0200 [thread overview]
Message-ID: <20111010230558.GA12009@nb.net.home> (raw)
In-Reply-To: <20111010194545.GB8822@rampage>
On Mon, Oct 10, 2011 at 03:45:45PM -0400, Dave Reisner wrote:
> On Sun, Oct 09, 2011 at 11:12:04AM -0400, Dave Reisner wrote:
> > There's only one condition for which we declare success, but many for
> > failure. Initialize rc as failure and set to success on this single
> > condition. In all cases, jump to a label to exit instead of exiting
> > immediately. This will be used later on to ease cleanup of any heap
> > allocations.
Well, free() before exit() is usually waste of time... but maybe we
can think about mountpoint(1) as about libmount test application,
then it would be nice to keep it without leaks (for example for
valgrind).
> @Karel: I can resend this if you like.
go ahead, thanks
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-10-10 23:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 15:12 [PATCH 1/2] mountpoint: refactor exit path Dave Reisner
2011-10-09 15:12 ` [PATCH 2/2] mountpoint: support symbolic and relative paths Dave Reisner
2011-10-10 19:45 ` [PATCH 1/2] mountpoint: refactor exit path Dave Reisner
2011-10-10 23:05 ` Karel Zak [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-10 23:14 Dave Reisner
2011-10-11 7:07 ` Voelker, Bernhard
2011-10-11 7:44 ` Karel Zak
2011-10-11 7:55 ` Voelker, Bernhard
2011-10-11 8:14 ` Karel Zak
2011-10-11 9:06 ` Karel Zak
2011-10-11 9:31 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010230558.GA12009@nb.net.home \
--to=kzak@redhat.com \
--cc=d@falconindy.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).