From: Karel Zak <kzak@redhat.com>
To: Dave Reisner <d@falconindy.com>
Cc: util-linux@vger.kernel.org, Dave Reisner <dreisner@archlinux.org>
Subject: Re: [PATCH 1/2] mountpoint: refactor exit path
Date: Tue, 11 Oct 2011 11:06:03 +0200 [thread overview]
Message-ID: <20111011090603.GJ11730@nb.net.home> (raw)
In-Reply-To: <1318288456-22940-1-git-send-email-dreisner@archlinux.org>
On Mon, Oct 10, 2011 at 07:14:15PM -0400, Dave Reisner wrote:
> if (dev_devno)
> rc = print_devno(spec, &st);
print_devno() returns -1 on error. Fixed.
> @@ -161,20 +161,23 @@ int main(int argc, char **argv)
>
> if (!S_ISDIR(st.st_mode)) {
> if (!quiet)
> - errx(EXIT_FAILURE, _("%s: not a directory"), spec);
> - return EXIT_FAILURE;
> + warnx(_("%s: not a directory"), spec);
> + goto finish;
> }
> src = dir_to_device(spec);
> if (src == (dev_t)-1) {
> if (!quiet)
> printf(_("%s is not a mountpoint\n"), spec);
> - return EXIT_FAILURE;
> + goto finish;
> }
> if (fs_devno)
> printf("%u:%u\n", major(src), minor(src));
> - else if (!quiet)
> + else if (!quiet) {
> printf(_("%s is a mountpoint\n"), spec);
> + rc = EXIT_SUCCESS;
Fixed. (see Berny's email)
Applied, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-10-11 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 23:14 [PATCH 1/2] mountpoint: refactor exit path Dave Reisner
2011-10-10 23:14 ` [PATCH 2/2] mountpoint: support symbolic and relative paths Dave Reisner
2011-10-11 9:34 ` Karel Zak
2011-10-11 7:07 ` [PATCH 1/2] mountpoint: refactor exit path Voelker, Bernhard
2011-10-11 7:44 ` Karel Zak
2011-10-11 7:55 ` Voelker, Bernhard
2011-10-11 8:14 ` Karel Zak
2011-10-11 9:06 ` Karel Zak [this message]
2011-10-11 9:31 ` Karel Zak
-- strict thread matches above, loose matches on Subject: below --
2011-10-09 15:12 Dave Reisner
2011-10-10 19:45 ` Dave Reisner
2011-10-10 23:05 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011090603.GJ11730@nb.net.home \
--to=kzak@redhat.com \
--cc=d@falconindy.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).