From: Petr Uzel <petr.uzel@suse.cz>
To: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 1/2] fdisk: don't shorten long path to disk device
Date: Wed, 12 Oct 2011 10:55:43 +0200 [thread overview]
Message-ID: <20111012085543.GC11839@foxbat.suse.cz> (raw)
In-Reply-To: <20111012082550.GA9667@nb.net.home>
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On Wed, Oct 12, 2011 at 10:25:50AM +0200, Karel Zak wrote:
> On Mon, Oct 10, 2011 at 03:12:17PM +0200, Petr Uzel wrote:
> > fdisk/partname.c:partname() uses fixed 80 char static buffer for partition
> > name. This might be not enough if the used path to the disk device is long
> > enough, e.g.
> [...]
> > - static char bufp[80];
> > + char *bufp;
>
> Hmm, after review... your idea to increase the static buffer
> size to PATH_MAX seems less invasive ;-)
>
> - static char bufp[80];
> + static char bufp[PATH_MAX];
I agree.
Thanks,
P.
--
Petr Uzel
IRC: ptr_uzl @ freenode
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2011-10-12 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 13:12 [PATCH 1/2] fdisk: don't shorten long path to disk device Petr Uzel
2011-10-10 13:12 ` [PATCH 2/2] fdisk: plug memory leak Petr Uzel
2011-10-12 8:25 ` [PATCH 1/2] fdisk: don't shorten long path to disk device Karel Zak
2011-10-12 8:55 ` Petr Uzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012085543.GC11839@foxbat.suse.cz \
--to=petr.uzel@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox