From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] prlimit: add a units column
Date: Wed, 26 Oct 2011 23:25:38 +0200 [thread overview]
Message-ID: <20111026212538.GA24870@nb.redhat.com> (raw)
In-Reply-To: <1319452258.2170.7.camel@offworld>
On Mon, Oct 24, 2011 at 12:30:58PM +0200, Davidlohr Bueso wrote:
> + [AS] = { "AS", N_("address space limit"), "bytes", RLIMIT_AS },
> + [CORE] = { "CORE", N_("max core file size"), "blocks", RLIMIT_CORE },
> + [CPU] = { "CPU", N_("CPU time"), "seconds", RLIMIT_CPU },
> + [DATA] = { "DATA", N_("max data size"), "bytes", RLIMIT_DATA },
> + [FSIZE] = { "FSIZE", N_("max file size"), "blocks", RLIMIT_FSIZE },
> + [LOCKS] = { "LOCKS", N_("max amount of file locks held"), NULL, RLIMIT_LOCKS },
> + [MEMLOCK] = { "MEMLOCK", N_("max locked-in-memory address space"), "kbytes", RLIMIT_MEMLOCK },
> + [MSGQUEUE] = { "MSGQUEUE", N_("max bytes in POSIX mqueues"), "bytes", RLIMIT_MSGQUEUE },
> + [NICE] = { "NICE", N_("max nice prio allowed to raise"), NULL, RLIMIT_NICE },
> + [NOFILE] = { "NOFILE", N_("max amount of open files"), NULL, RLIMIT_NOFILE },
> + [NPROC] = { "NPROC", N_("max number of processes"), NULL, RLIMIT_NPROC },
> + [RSS] = { "RSS", N_("max resident set size"), "pages", RLIMIT_RSS },
> + [RTPRIO] = { "RTPRIO", N_("max real-time priority"), NULL, RLIMIT_RTPRIO },
> + [RTTIME] = { "RTTIME", N_("timeout for real-time tasks"), "microsecs", RLIMIT_RTTIME },
> + [SIGPENDING] = { "SIGPENDING", N_("max amount of pending signals"), NULL, RLIMIT_SIGPENDING },
> + [STACK] = { "STACK", N_("max stack size"), "kbytes", RLIMIT_STACK }
Why without N_() ?
> + case COL_UNITS:
> + rc = l->desc->unit ? asprintf(&str, "%s", l->desc->unit) :
> + asprintf(&str, "------");
> + break;
str = l->desc->unit ? xstrdup(_(l->desc->unit)) : NULL;
NULL should not be a problem for tt_* functions.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-10-26 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 10:30 [PATCH] prlimit: add a units column Davidlohr Bueso
2011-10-26 21:25 ` Karel Zak [this message]
2011-11-02 17:40 ` Davidlohr Bueso
2011-11-07 8:58 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026212538.GA24870@nb.redhat.com \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).