Util-Linux package development
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: util-linux@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>,
	Petr Uzel <petr.uzel@suse.cz>
Subject: flock in 2.20.1 can no longer lock the file it will execute
Date: Mon, 14 Nov 2011 01:23:38 -0500	[thread overview]
Message-ID: <201111140123.39789.vapier@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

i've been using a trick with flock to add locking to all of my shell scripts.  
basically, i take a lock on the shell script itself:
	flock -eon ./test.sh ./test.sh

with <=util-linux-2.20, this has worked fine.  but starting with 2.20.1, i now 
get -ETXTBSY (on ext4, but i doubt that matters):
	$ echo '#!/bin/sh' > test.sh
	$ chmod a+rx test.sh 
	$ ./flock -eon ./test.sh ./test.sh 
	./flock: ./test.sh: Text file busy

the only commit made to flock.c between 2.20 and 2.20.1 is this:
	commit 75aaee08f06b92d119ed827c53d1af5474eb16ff
	flock: make flock(1) work on NFSv4

and indeed, reverting that made my life happy again.  reading the small patch 
shows the obvious flaw: you can't open a file for O_RDWR and attempt to execute 
it at the same time.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2011-11-14  6:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14  6:23 Mike Frysinger [this message]
2011-11-16 13:13 ` flock in 2.20.1 can no longer lock the file it will execute Karel Zak
2011-11-16 15:25   ` Mike Frysinger
2011-11-21 16:35     ` Karel Zak
2011-11-21 20:11       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111140123.39789.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=mkubecek@suse.cz \
    --cc=petr.uzel@suse.cz \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox