From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: util-linux <util-linux@vger.kernel.org>,
Harald Hoyer <harald@redhat.com>
Subject: Re: [pull] third sys-utils patch set
Date: Mon, 14 Nov 2011 13:45:28 +0100 [thread overview]
Message-ID: <20111114124528.GA20881@nb.net.home> (raw)
In-Reply-To: <CAG27Bk1acCRkXM=6wf5BRZ_Q6niOheappANqBKHiObZv86GL2g@mail.gmail.com>
On Wed, Nov 02, 2011 at 08:28:43PM +0100, Sami Kerola wrote:
> The switch_root did not use translations. I wonder was that
> intentional, and it should not have them? If so the patch has to be
> knocked out.
It was probably intentional (I don't remember:-) to ignore NLS in
switch_root(8), but I think that all utils should be able follow
locales setting if you ask for --help or --version. I don't see a
technical reason to disable NLS in switch_root(8).
> The ldattach usage output 'Known ... names' output tables are now
> wider and shorter. IMHO that is better, since the usage is a lot
> longer than it used to be. My only question is that should the output
> tables be more smart, and use tt_print_table() combined with terminal
> width detection to make table as wide as possible?
No, please, don't use tt in usage(), it's horrible overkill.
> are available in the git repository at:
> https://github.com/kerolasa/lelux-utiliteetit sys-utils-3rd
Merged. Thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2011-11-14 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 19:28 [pull] third sys-utils patch set Sami Kerola
2011-11-14 12:45 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114124528.GA20881@nb.net.home \
--to=kzak@redhat.com \
--cc=harald@redhat.com \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).