[pull] third sys-utils patch set

[pull] third sys-utils patch set

[Sami Kerola]

Hello,

Here's remaining usage(), howto alignment, code style fix patches
about utilities in sys-utils directory. Many of the patches are
trivial, but there are couple which I want to mention.

The switch_root did not use translations. I wonder was that
intentional, and it should not have them? If so the patch has to be
knocked out.

The ldattach usage output 'Known ... names' output tables are now
wider and shorter. IMHO that is better, since the usage is a lot
longer than it used to be. My only question is that should the output
tables be more smart,  and use tt_print_table() combined with terminal
width detection to make table as wide as possible?

Rest is ready for review.


The following changes since commit 6bac2825af7216c5471148e219dbcf62ec5ede84:

  prlimit: new command (2011-10-21 23:19:51 +0200)

are available in the git repository at:
  https://github.com/kerolasa/lelux-utiliteetit sys-utils-3rd

Sami Kerola (20):
      setsid: add long options and fix coding style
      rtcwake: align with howto-usage-function.txt
      unshare: align with howto-usage-function.txt
      switch_root: align with howto-usage-function.txt
      switch_root: add nls support
      tunelp: fix coding style
      tunelp: use symbolic exit values
      tunelp: use libc error printing facilities
      tunelp: add long options and align with howto-usage-function.txt
      docs: add long options to tunelp.8
      docs: align tunelp.8 with howto-man-page.txt
      readprofile: add long options
      readprofile: use libc error printing facilities
      readprofile: fix coding style
      docs: add long options to readprofile.8
      ldattach: fix coding style
      ldattach: align with howto-usage-function.txt
      ldattach: check numeric user inputs with strtol_or_err
      ldattach: convert debug macro to function
      ldattach: add default case to switches

 sys-utils/Makefile.am   |    1 +
 sys-utils/ldattach.c    |  477 +++++++++++++++++++++++++----------------------
 sys-utils/readprofile.8 |  148 +++++++--------
 sys-utils/readprofile.c |  292 +++++++++++++++---------------
 sys-utils/rtcwake.c     |   16 +-
 sys-utils/setsid.c      |   73 +++++--
 sys-utils/switch_root.c |   55 +++---
 sys-utils/tunelp.8      |  227 +++++++++-------------
 sys-utils/tunelp.c      |  456 ++++++++++++++++++++++++--------------------
 sys-utils/unshare.c     |   19 ++-
 10 files changed, 913 insertions(+), 851 deletions(-)

-- 
   Sami Kerola
   http://www.iki.fi/kerolasa/

Re: [pull] third sys-utils patch set

[Karel Zak]

On Wed, Nov 02, 2011 at 08:28:43PM +0100, Sami Kerola wrote:
> The switch_root did not use translations. I wonder was that
> intentional, and it should not have them? If so the patch has to be
> knocked out.

 It was probably intentional (I don't remember:-) to ignore NLS in
 switch_root(8), but I think that all utils should be able follow
 locales setting if you ask for --help or --version. I don't see a
 technical reason to disable NLS in switch_root(8).

> The ldattach usage output 'Known ... names' output tables are now
> wider and shorter. IMHO that is better, since the usage is a lot
> longer than it used to be. My only question is that should the output
> tables be more smart,  and use tt_print_table() combined with terminal
> width detection to make table as wide as possible?

 No, please, don't use tt in usage(), it's horrible overkill.

> are available in the git repository at:
>   https://github.com/kerolasa/lelux-utiliteetit sys-utils-3rd

 Merged. Thanks.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com