From: Karel Zak <kzak@redhat.com>
To: Francesco Cosoleto <cosoleto@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 1/5] fdisk: print the welcome message when OSF/1 disklabel is detected
Date: Mon, 14 Nov 2011 14:42:59 +0100 [thread overview]
Message-ID: <20111114134259.GB20881@nb.net.home> (raw)
In-Reply-To: <1321006331-7633-1-git-send-email-cosoleto@gmail.com>
On Fri, Nov 11, 2011 at 11:12:07AM +0100, Francesco Cosoleto wrote:
> fdisk/fdisk.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
Applied (all patches), thanks.
> gpt_warning(disk_device);
> get_boot(fdisk);
>
> + fprintf(stderr, _("Welcome to fdisk (%s).\n\n"
> + "Changes will remain in memory only, until you decide to write them.\n"
> + "Be careful before using the write command.\n"), PACKAGE_STRING);
> +
I have moved this message before gpt_warning() and get_boot(). The
get_boot() produces very often warnings (for example on disk with no
PT) and I think that the welcome message should be printed as very
first message in the interactive mode.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-11-14 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 10:12 [PATCH 1/5] fdisk: print the welcome message when OSF/1 disklabel is detected Francesco Cosoleto
2011-11-11 10:12 ` [PATCH 2/5] fdisk: rename bselect, xselect functions Francesco Cosoleto
2011-11-11 10:12 ` [PATCH 3/5] fdisk: move command prompt code to a separate function Francesco Cosoleto
2011-11-11 10:12 ` [PATCH 4/5] fdisk: rewrite print menu system Francesco Cosoleto
2011-11-11 11:40 ` Karel Zak
2011-11-11 16:49 ` Francesco Cosoleto
2011-11-11 10:12 ` [PATCH 5/5] fdisk: enable expert menu with SGI label Francesco Cosoleto
2011-11-14 13:42 ` Karel Zak [this message]
2011-11-14 16:03 ` [PATCH 1/5] fdisk: print the welcome message when OSF/1 disklabel is detected Francesco Cosoleto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114134259.GB20881@nb.net.home \
--to=kzak@redhat.com \
--cc=cosoleto@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).