From: Karel Zak <kzak@redhat.com>
To: Maurizio Lombardi <m.lombardi85@gmail.com>
Cc: dave@gnu.org, util-linux@vger.kernel.org
Subject: Re: mkfs.minix V3 is broken
Date: Tue, 22 Nov 2011 11:54:49 +0100 [thread overview]
Message-ID: <20111122105449.GX7916@nb.net.home> (raw)
In-Reply-To: <CAMtsiiDNPk4+m7JoWRp0JQWdL229OMCMYjZZsg-E2Ej0Rkv4OA@mail.gmail.com>
On Tue, Nov 22, 2011 at 11:05:04AM +0100, Maurizio Lombardi wrote:
> > if (BLOCKS > MINIX_MAX_INODES)
> > BLOCKS = MINIX_MAX_INODES;
>
> Please note that this piece of code is horrible too, comparing the
> number of blocks to the max number of inodes is like comparing apples
> and oranges, no? :)
>
> In general I think that the mkfs.minix is full of weird things and
> needs a serious cleanup.
Go ahead! :-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-11-22 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 19:40 mkfs.minix V3 is broken Maurizio Lombardi
2011-11-21 22:06 ` Davidlohr Bueso
2011-11-22 9:03 ` Maurizio Lombardi
2011-11-22 10:05 ` Maurizio Lombardi
2011-11-22 10:54 ` Karel Zak [this message]
2011-11-27 22:03 ` Davidlohr Bueso
2011-11-28 9:27 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122105449.GX7916@nb.net.home \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=m.lombardi85@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).