From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 2/2] build-sys: check HAVE_ definitions with #ifdef [smatch scan]
Date: Fri, 2 Dec 2011 18:29:17 +0100 [thread overview]
Message-ID: <20111202172917.GB28962@nb.net.home> (raw)
In-Reply-To: <1322777421-11541-2-git-send-email-kerolasa@iki.fi>
On Thu, Dec 01, 2011 at 11:10:21PM +0100, Sami Kerola wrote:
> include/blkdev.h | 2 +-
> include/md5.h | 2 +-
> lib/env.c | 2 +-
> lib/ismounted.c | 2 +-
> libblkid/src/cache.c | 2 +-
> libblkid/src/devname.c | 8 ++++----
> libblkid/src/devno.c | 10 +++++-----
> libblkid/src/llseek.c | 6 +++---
> libblkid/src/read.c | 4 ++--
> libblkid/src/resolve.c | 2 +-
> libblkid/src/version.c | 2 +-
> misc-utils/cal.c | 2 +-
> term-utils/script.c | 10 +++++++---
> 13 files changed, 29 insertions(+), 25 deletions(-)
Applied, thanks.
>> -#if HAVE_LIBUTIL && HAVE_PTY_H
> +#ifdef HAVE_LIBUTIL
> +# ifdef HAVE_PTY_H
here we can use:
#if defined(HAVE_LIBUTIL) && defined(HAVE_PTY_H)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-12-02 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 22:10 [PATCH 1/2] build-sys: add missing headers to dist Sami Kerola
2011-12-01 22:10 ` [PATCH 2/2] build-sys: check HAVE_ definitions with #ifdef [smatch scan] Sami Kerola
2011-12-02 17:29 ` Karel Zak [this message]
2011-12-02 17:22 ` [PATCH 1/2] build-sys: add missing headers to dist Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202172917.GB28962@nb.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).