From: Karel Zak <kzak@redhat.com>
To: Phillip Susi <psusi@cfl.rr.com>
Cc: dave@gnu.org, util-linux@vger.kernel.org
Subject: Re: [PATCH 2/4] partx: add BLKPG_RES_PARTITION support
Date: Thu, 8 Dec 2011 13:15:27 +0100 [thread overview]
Message-ID: <20111208121527.GC8278@nb.redhat.com> (raw)
In-Reply-To: <4EDE6745.6070307@cfl.rr.com>
On Tue, Dec 06, 2011 at 02:04:37PM -0500, Phillip Susi wrote:
> On 12/6/2011 1:55 PM, Davidlohr Bueso wrote:
>> I like the idea, but we should wait until your BLKPG resize patches are
>> accepted in mainline before applying here. Also, assuming they make it
>> into the kernel, this patch would break partx compilation on older
>> kernels.
>
> Indeed. I thought that util-linux was closely enough tied to the kernel
> that it didn't care about building on older kernels? I put #ifdefs
> around the code using it in parted, but didn't think it was needed for
> util-linux.
The command line (our API) should not depend on kernel features, so
we usually use fallback definitions (see for example include/blkdev.h)
in case that libc/kernel header files are too old.
> Easy enough to add them back if you think it's necessary.
This is detail ;-) I'll fix it before commit.
The more important is to have kernel part in Linus' tree...
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2011-12-08 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 20:02 [PATCH 2/4] partx: add BLKPG_RES_PARTITION support Phillip Susi
2011-12-06 18:55 ` Davidlohr Bueso
2011-12-06 19:04 ` Phillip Susi
2011-12-08 12:15 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208121527.GC8278@nb.redhat.com \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=psusi@cfl.rr.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).