From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] lists: add list sorting routine
Date: Tue, 13 Dec 2011 12:46:42 +0100 [thread overview]
Message-ID: <20111213114642.GB22851@nb.net.home> (raw)
In-Reply-To: <1323773786.3256.1.camel@offbook>
On Tue, Dec 13, 2011 at 11:56:26AM +0100, Davidlohr Bueso wrote:
> On Tue, 2011-12-13 at 10:26 +0100, Karel Zak wrote:
> > On Mon, Dec 12, 2011 at 11:55:57PM +0100, Davidlohr Bueso wrote:
> > > One note: the code is added to the header file instead of its own C file
> > > so we don't have to update all the build rules of the list.h users.
> >
> > [...]
> >
> > > > +static struct list_head *merge(int (*cmp)(struct list_head *a,
> > > > + struct list_head *b),
> > > > + struct list_head *a, struct list_head *b)
> >
> > shouldn't be the function "static inline" (or _INLINE_ ) ?
>
> Hmm yes, do you want me to send another patch with the correction?
No, I'll fix it.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-12-13 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 22:52 [PATCH] lists: add list sorting routine Davidlohr Bueso
2011-12-12 22:55 ` Davidlohr Bueso
2011-12-13 9:26 ` Karel Zak
2011-12-13 10:56 ` Davidlohr Bueso
2011-12-13 11:46 ` Karel Zak [this message]
2011-12-16 11:42 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213114642.GB22851@nb.net.home \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).