From: Karel Zak <kzak@redhat.com>
To: Dave Reisner <d@falconindy.com>
Cc: util-linux@vger.kernel.org, Dave Reisner <dreisner@archlinux.org>
Subject: Re: [PATCH 1/2] findmnt: use warnx for libmnt error callback
Date: Fri, 16 Dec 2011 11:43:53 +0100 [thread overview]
Message-ID: <20111216104353.GD25486@nb.net.home> (raw)
In-Reply-To: <1323629885-17940-2-git-send-email-dreisner@archlinux.org>
On Sun, Dec 11, 2011 at 01:58:04PM -0500, Dave Reisner wrote:
> misc-utils/findmnt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/misc-utils/findmnt.c b/misc-utils/findmnt.c
> index 9c2b9fc..4577dc6 100644
> --- a/misc-utils/findmnt.c
> +++ b/misc-utils/findmnt.c
> @@ -484,7 +484,7 @@ leave:
> static int parser_errcb(struct libmnt_table *tb __attribute__ ((__unused__)),
> const char *filename, int line)
> {
> - warn(_("%s: parse error at line %d"), filename, line);
> + warnx(_("%s: parse error at line %d"), filename, line);
Oh.. yes, errno does not make sense here. Applied, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-12-16 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 18:58 [PATCH 0/2] Add user-defined fstab location for findmnt Dave Reisner
2011-12-11 18:58 ` [PATCH 1/2] findmnt: use warnx for libmnt error callback Dave Reisner
2011-12-16 10:43 ` Karel Zak [this message]
2011-12-11 18:58 ` [PATCH 2/2] findmnt: support alternative location of fstab Dave Reisner
2011-12-16 10:48 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216104353.GD25486@nb.net.home \
--to=kzak@redhat.com \
--cc=d@falconindy.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).