From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: Dave Reisner <d@falconindy.com>,
util-linux@vger.kernel.org, Dave Reisner <dreisner@archlinux.org>
Subject: Re: [PATCH 1/3] column: use xalloc libs
Date: Wed, 4 Jan 2012 14:37:10 +0100 [thread overview]
Message-ID: <20120104133710.GC24350@x2.net.home> (raw)
In-Reply-To: <1324390416.3316.13.camel@offbook>
On Tue, Dec 20, 2011 at 03:13:36PM +0100, Davidlohr Bueso wrote:
> On Tue, 2011-12-20 at 08:36 -0500, Dave Reisner wrote:
> > text-utils/column.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
> > - wcs = malloc((n + 1) * sizeof(wchar_t));
> > + wcs = xmalloc((n + 1) * sizeof(wchar_t));
> > if (!wcs)
> > return NULL;
>
> Hmm this isn't that straight forward, if the memory allocation fails
> here we don't necessarily abort the program.
Fixed.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-01-04 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 13:36 [PATCH 1/3] column: use xalloc libs Dave Reisner
2011-12-20 13:36 ` [PATCH 2/3] lscpu: " Dave Reisner
2012-01-04 13:37 ` Karel Zak
2011-12-20 13:36 ` [PATCH 3/3] tools/checkxalloc.sh: add new code checking script Dave Reisner
2012-01-04 13:39 ` Karel Zak
2011-12-20 14:13 ` [PATCH 1/3] column: use xalloc libs Davidlohr Bueso
2012-01-04 13:37 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104133710.GC24350@x2.net.home \
--to=kzak@redhat.com \
--cc=d@falconindy.com \
--cc=dave@gnu.org \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).