Re: sfdisk 2.20.1 --no-reread do BLKRRPART

Bertrand Jacquin
2013-05-21T13:41:19Z

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

Hi,

Le lundi 20 mai 2013 à 13h15, « Karel Zak » a écrit :
>
> Sorry for the delay :-)

No rush at all ! This was only a report about some ugly report in some
scripts :)

> On Thu, Feb 16, 2012 at 09:16:18PM +0100, Bertrand Jacquin wrote:
> > When creating partitions on a destination that is not a block device,
> > sfdisk do a BLKRRPART ioctl even when --no-reread option is used, but
> > looking at documentation --no-reread only apply to the beginning
> > process.
> >
> > Would it be fine to extend that to the complete process ?
>
> Not sure, but I think it should be enough to don't call BLKRRPART
> ioctl for non-block devices.
>
> > dd if=/dev/zero of=/tmp/disk.img bs=1024 count=4032
> > strace -fF -s 1024 -e trace=ioctl \
> > sfdisk --no-reread -C2 -H32 -S63 -q -f \
> > /tmp/disk.img << EOF
> > unit: sectors
> >
> > part1 : start= 63, size= 3969, Id=83
> > part2 : start= 4032, size= 98784, Id=83
> > part3 : start= 102816, size= 22176, Id=83
> > part4 : start= 124992, size= 0, Id=83
> > EOF
>
> ...
>
> > Re-reading the partition table ...
> > ioctl(3, BLKRRPART, 0) = -1 ENOTTY (Inappropriate ioctl for device)
> > BLKRRPART: Inappropriate ioctl for device
>
> This use case (disk images partitioning) should be fixed in the git
> tree.

Seen and approved ! Thanks Karel

--
Bertrand Jacquin, EXOSEC (http://www.exosec.fr/)
ZAC des Metz - 3 Rue du petit robinson - 78350 JOUY EN JOSAS
Tel: +33 1 30 67 60 65 - Fax: +33 1 75 43 40 70
GSM: +33 6 71 01 70 30 - mailto:bjacquin@exosec.fr

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]