Re: [PATCH 11/20] uuidd: introduce --keep-privs option

Karel Zak
2012-04-03T13:32:54Z

On Thu, Mar 29, 2012 at 06:45:19PM +0200, Petr Uzel wrote:
> This option makes uuidd _not_ to drop its privileges if installed suid
> and exectued by root.
>
> Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
> ---
> misc-utils/uuidd.8 | 5 +++++
> misc-utils/uuidd.c | 7 ++++++-
> 2 files changed, 11 insertions(+), 1 deletions(-)

Please, drop this patch.

For socket activation we can use the "drop_privs = 0" internally, it's
unnecessary to export this functionality to command line.

Anyway, do we really need to support suid uuidd? What about to drop
all this stuff and require that uuidd has to be started by init
scripts only? What about to drop exec-from-library at all?

RHEL/Fedora/Suse starts uuidd by init, and for another distros is
whole uuidd almost unnecessary thing... It seems that Debian uses
suid uuidd, but I think that they can add an init script too.

IMHO the current exec-from-library and suid is not elegant solution.

Ted?

Karel

--
Karel Zak <kzak@redhat.com>