From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: util-linux-owner@vger.kernel.org Received: from cantor2.suse.de ([195.135.220.15]:41057 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850Ab2DJMUR convert rfc822-to-8bit (ORCPT ); Tue, 10 Apr 2012 08:20:17 -0400 Date: Tue, 10 Apr 2012 14:20:16 +0200 From: Petr Uzel To: util-linux Cc: Davidlohr Bueso Subject: Re: [PATCH 3/3] libuuid: use randutils Message-ID: <20120410122016.GB11753@foxbat.suse.cz> References: <1333662730.2696.6.camel@offbook> <20120410113150.GN19784@x2.net.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20120410113150.GN19784@x2.net.home> Sender: util-linux-owner@vger.kernel.org List-ID: On Tue, Apr 10, 2012 at 01:31:50PM +0200, Karel Zak wrote: > On Thu, Apr 05, 2012 at 11:52:10PM +0200, Davidlohr Bueso wrote: > > libuuid/src/Makefile.am | 3 +- > > libuuid/src/gen_uuid.c | 99 ++-------------------------------------------- > > 2 files changed, 7 insertions(+), 95 deletions(-) > > Applied, thanks. > > > @@ -703,7 +614,7 @@ void uuid_generate_random(uuid_t out) > > */ > > void uuid_generate(uuid_t out) > > { > > - if (get_random_fd() >= 0) > > + if (random_get_fd() >= 0) > > uuid_generate_random(out); > > This sucks: > > - because we call random_get_fd() in __uuid_generate_random again: > > $ strace -e open ./misc-utils/uuidgen > open("/dev/urandom", O_RDONLY) = 3 > open("/dev/urandom", O_RDONLY) = 4 > > it would be better to add 'fd' argument to __uuid_generate_random(), > use it in uuid_generate() and reuse the file descriptor if >= 0. > > We use __uuid_generate_random in the library and in uuidd, so we > don't have to care about API there. > > - it's file descriptor leak in shared library... > > Volunteers? ;-) If nobody steps out, I can include this in my uuidd systemd-ization series (which I'll hopefully finish this week). Petr -- Petr Uzel IRC: ptr_uzl @ freenode