Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Karel Zak <kzak@redhat.com>]

On Tue, Apr 17, 2012 at 03:32:15PM +0100, Pádraig Brady wrote:
> On 04/17/2012 03:14 PM, Bernhard Voelker wrote:
> > On 04/17/2012 03:56 PM, Pádraig Brady wrote:
> >> On 04/17/2012 09:42 AM, Bernhard Voelker wrote:
> >>> Karel Zak wrote:
> >>>
> >>>> On Mon, Apr 16, 2012 at 12:22:12PM +0200, Voelker, Bernhard wrote:
> >>>>> Maybe this is better?
> >>>>>
> >>>>> -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
> >>>>> +	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"
> >>
> >> Blocks are 1024 bytes in this mode, as confirmed with:
> >> sfdisk -uM -l /dev/sda
> > 
> > I don't understand. What's wrong?
> > 
> > $ wc -c </dev/sda1
> > 12582912000
> > 
> > $ echo '12582912000 / (1024*1024)' | bc
> > 12000
> > 
> > $ ./sfdisk -uM -l /dev/sda | egrep 'sda1|MiB'
> > Units = 1MiB, blocks of 1024*1024 bytes, counting from 0
> >    Device Boot Start   End    MiB    #blocks   Id  System
> > /dev/sda1   *     1  12000  12000   12288000   83  Linux
> 
> Well I thought the "blocks of" was referring to the blocks column,
> rather than the units?
> 
> $ echo $((12582912000 / 1024))
> 12288000

 yep, my +1 was about s/mebibytes/MiB/, I have overlooked the
 1024*1024 math in the patch. Pádraig is right, (s)fdisk uses 1024
 byte blocks in output (probably too keep things more confusing ;-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com