From: Karel Zak <kzak@redhat.com>
To: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Cc: "util-linux@vger.kernel.org" <util-linux@vger.kernel.org>
Subject: Re: [PATCH] login-utils: use getdtablesize() correctly in login.c
Date: Mon, 23 Apr 2012 14:02:44 +0200 [thread overview]
Message-ID: <20120423120244.GI11847@x2.net.home> (raw)
In-Reply-To: <20120420105828.554ce55a@thirdoffive.cmf.nrl.navy.mil>
On Fri, Apr 20, 2012 at 10:58:28AM -0400, chas williams - CONTRACTOR wrote:
> login-utils: use getdtablesize() correctly in login.c
>
> getdtablesize() is the number of descriptors and since decriptors start
> at 0, its value isnt the largest descriptors possible. One should use
> getdtablesize() - 1 instead.
Applied, thanks.
I have also added fallback for the getdtablesize() to lib/fileutils.c, it
seems that the function is not too portable.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-04-23 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 14:58 [PATCH] login-utils: use getdtablesize() correctly in login.c chas williams - CONTRACTOR
2012-04-23 12:02 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423120244.GI11847@x2.net.home \
--to=kzak@redhat.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox