Re: [PATCH 3/3] libuuid: use randutils

[Petr Uzel <petr.uzel@suse.cz>]

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

On Tue, Apr 10, 2012 at 01:31:50PM +0200, Karel Zak wrote:
> On Thu, Apr 05, 2012 at 11:52:10PM +0200, Davidlohr Bueso wrote:
> >  libuuid/src/Makefile.am |    3 +-
> >  libuuid/src/gen_uuid.c  |   99 ++--------------------------------------------
> >  2 files changed, 7 insertions(+), 95 deletions(-)
> 
>  Applied, thanks.
> 
> > @@ -703,7 +614,7 @@ void uuid_generate_random(uuid_t out)
> >   */
> >  void uuid_generate(uuid_t out)
> >  {
> > -	if (get_random_fd() >= 0)
> > +	if (random_get_fd() >= 0)
> >  		uuid_generate_random(out);
> 
> This sucks:
> 
>  - because we call random_get_fd() in __uuid_generate_random again:
> 
>    $ strace -e open ./misc-utils/uuidgen
>    open("/dev/urandom", O_RDONLY)          = 3
>    open("/dev/urandom", O_RDONLY)          = 4
> 
>    it would be better to add 'fd' argument to __uuid_generate_random(),
>    use it in uuid_generate() and reuse the file descriptor if >= 0. 
> 
>    We use __uuid_generate_random in the library and in uuidd, so we
>    don't have to care about API there.
> 
>  - it's file descriptor leak in shared library...
> 
>  Volunteers? ;-)

Patch addressing this is included in the uuidd series I sent shortly
before. But please check the note about it in the series cover letter.

Thanks,

Petr

-- 
Petr Uzel
IRC: ptr_uzl @ freenode

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]