public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Uzel <petr.uzel@suse.cz>
To: Davidlohr Bueso <dave@gnu.org>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 2/5] fdisk: move DOS new/add partition code
Date: Sun, 6 May 2012 19:58:46 +0200	[thread overview]
Message-ID: <20120506175846.GA6429@skipper.site> (raw)
In-Reply-To: <1336306218.2685.11.camel@offbook>

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On Sun, May 06, 2012 at 02:10:18PM +0200, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>  
> Since this is DOS specific logic, it belongs in its own label file. Additionally, a dos_new_partition() function is created
> that asks the user for partition type and then calls the actual dos_add_partition().
> 
> This patch passed fdisk regression tests, builds without problems and it was locally tested against adding and removing DOS partitions.
> 
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>

Reviewed-and-acked-by: Petr Uzel <petr.uzel@suse.cz>

> ---
>  fdisk/fdisk.c         |  354 ++-----------------------------------------------
>  fdisk/fdisk.h         |   22 +++-
>  fdisk/fdiskdoslabel.c |  332 ++++++++++++++++++++++++++++++++++++++++++++++
>  fdisk/fdiskdoslabel.h |    5 +-
>  4 files changed, 365 insertions(+), 348 deletions(-)
[SNIP]

Petr

--
Petr Uzel
IRC: ptr_uzl @ freenode

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-05-06 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-06 12:10 [PATCH 2/5] fdisk: move DOS new/add partition code Davidlohr Bueso
2012-05-06 17:58 ` Petr Uzel [this message]
2012-05-10  9:50 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120506175846.GA6429@skipper.site \
    --to=petr.uzel@suse.cz \
    --cc=dave@gnu.org \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox