From: Karel Zak <kzak@redhat.com>
To: Petr Uzel <petr.uzel@suse.cz>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] libuuid: avoid double open and leaking fd (reworked)
Date: Thu, 10 May 2012 11:54:38 +0200 [thread overview]
Message-ID: <20120510095438.GD30118@x2.net.home> (raw)
In-Reply-To: <1336334153-32532-1-git-send-email-petr.uzel@suse.cz>
On Sun, May 06, 2012 at 09:55:53PM +0200, Petr Uzel wrote:
> This is better than calling random_get_fd() twice, passing the file
> descriptor down the stack and reusing it in next call to
> random_get_fd().
Yep, nice :-)
> fdisk/fdiskdoslabel.c | 2 +-
> include/randutils.h | 2 +-
> lib/randutils.c | 8 +++-----
> libuuid/src/gen_uuid.c | 28 ++++++++++++++++++----------
> libuuid/src/uuidd.h | 2 +-
> misc-utils/uuidd.c | 4 ++--
> 6 files changed, 26 insertions(+), 20 deletions(-)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-05-10 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-06 19:55 [PATCH] libuuid: avoid double open and leaking fd (reworked) Petr Uzel
2012-05-10 9:54 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510095438.GD30118@x2.net.home \
--to=kzak@redhat.com \
--cc=petr.uzel@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox