From: Karel Zak <kzak@redhat.com>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] allow to create a minix3fs with a blocksize != 1K
Date: Tue, 15 May 2012 11:05:01 +0200 [thread overview]
Message-ID: <20120515090501.GA8268@x2.net.home> (raw)
In-Reply-To: <4FAAE7FB.2060808@gmail.com>
On Wed, May 09, 2012 at 11:56:11PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Have used it to test minixfs support with various block sizes.
Looks good, but
> +int MINIX_BLOCK_SIZE = 0;
is dirty, what about
int block_size = 0;
Vladimir, use also 'Signed-off-by:' in commit message for your patches, please.
Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-05-15 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4FAAE6EA.3080308@gmail.com>
2012-05-09 21:56 ` [PATCH] allow to create a minix3fs with a blocksize != 1K Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-15 9:05 ` Karel Zak [this message]
2012-06-10 19:58 ` Davidlohr Bueso
2012-06-10 20:21 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-06-11 11:45 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515090501.GA8268@x2.net.home \
--to=kzak@redhat.com \
--cc=phcoder@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).