From: Karel Zak <kzak@redhat.com>
To: Dave Reisner <dreisner@archlinux.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] mangle: check for end of string on every iteration
Date: Tue, 15 May 2012 11:33:56 +0200 [thread overview]
Message-ID: <20120515093356.GH8268@x2.net.home> (raw)
In-Reply-To: <1336936489-8203-1-git-send-email-dreisner@archlinux.org>
On Sun, May 13, 2012 at 03:14:49PM -0400, Dave Reisner wrote:
> Checking for the null byte at the end of the string only conditionally
> leads to segfaults, evidenced by mount helpers crashing on writes to
Ah.. sorry.
> /run/mount/utab. Simply check for the null on each iteration, and append
> a null byte to the mangled string before breaking.
>
> Signed-off-by: Dave Reisner <dreisner@archlinux.org>
> ---
> lib/mangle.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Applied, thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-05-15 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 19:14 [PATCH] mangle: check for end of string on every iteration Dave Reisner
2012-05-15 9:33 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515093356.GH8268@x2.net.home \
--to=kzak@redhat.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).