From: Karel Zak <kzak@redhat.com>
To: Ludwig Nussel <ludwig.nussel@suse.de>
Cc: util-linux@vger.kernel.org
Subject: Re: [PULL] su
Date: Fri, 25 May 2012 09:41:11 +0200 [thread overview]
Message-ID: <20120525074111.GB1177@x2.net.home> (raw)
In-Reply-To: <4FBE3059.3030806@suse.de>
On Thu, May 24, 2012 at 02:58:01PM +0200, Ludwig Nussel wrote:
> coreutils isn't really interested in maintaining su anymore.
> Distributions have to add custom patches to fix bugs and add
> features. The worst offender is probably the pam patch. Fortunately
> we managed to sync the patch between openSUSE and Fedora meanwhile.
> Over time the risk that the patches divert again increases though.
> Since util-linux now contains a common login program it looks like a
> good new home for su too.
>
> To integrate su into util-linux I've extracted the history of the su
> program until the last GPLv2 version (they've changed to GPLv3
> meanwhile) from coreutils' git and merged it with util-linux.
> Then I've added the patches used in Fedora and openSUSE and fixed the
> files to actually build.
Good work, thanks.
> You can find the result in branch su-v1 (ff6b15d) at
> git@github.com:lnussel/util-linux.git
>
> I've also filed a pull request on github:
> https://github.com/karelzak/util-linux/pull/10
>
> Originally I had planned to implement separate tty allocation for
> the child program on top of that to get rid of the evil setsid
> patch. It turned out to be more complicated than I thought though. The
> change would be too massive to backport anyways I guess. So the next
> step would be to rip out the non-pam legacy stuff and clean up the code
> to make it readable again.
It would be nice to cleanup the code (remove non-PAM stuff) before
merge. Can you do this in your su branch? Please.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-05-25 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 12:58 [PULL] su Ludwig Nussel
2012-05-25 7:41 ` Karel Zak [this message]
2012-05-25 9:55 ` Ludwig Nussel
2012-05-29 9:06 ` Karel Zak
2012-05-29 11:34 ` su(1) wish list Karel Zak
2012-05-29 12:15 ` Ludwig Nussel
2012-05-29 12:30 ` Voelker, Bernhard
2012-05-30 13:42 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525074111.GB1177@x2.net.home \
--to=kzak@redhat.com \
--cc=ludwig.nussel@suse.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).